Comments on: Lightweight JSONP javascript library

By: Gabriel

Gabriel — Fri, 06 Jan 2012 16:54:28 +0000

Hey, thank you very much for the code!

I just wanted to let you know that I found an improvement you can make to it.

When you say:

query = “?”;

Keep in mind that the request URL may already have a query string in it, and thus the “?” should be replaced with a “&”.

What do you think?

By: Ralph Bunker

Ralph Bunker — Tue, 21 Jun 2011 16:14:50 +0000

Thanks for the code. I feel that I fully understand the jsonp pattern now.

But why are you setting window[jsonp] to null after deleting it? Flanagan’s book does not use that pattern.

By: Erik Karlsson

Erik Karlsson — Wed, 08 Jun 2011 06:04:39 +0000

Of course it should. Thanks for pointing it out.

By: Bryan Smith

Bryan Smith — Sat, 04 Jun 2011 07:31:22 +0000

Thanks!

I think the sample code should try to delete window[jsonp] before setting it to null.

By: Slava Shkodin

Slava Shkodin — Thu, 05 May 2011 16:01:14 +0000

Hi, Erik. I have one question about your code (sorry, if it is a little bit stupid). I can’t understand why do you use both onload and onreadystatechange events? Why not simply onload?

By: Erik Karlsson

Erik Karlsson — Fri, 29 Apr 2011 06:17:21 +0000

@ysched: I’ve now updated the post with encodeURIComponent.

By: Erik Karlsson

Erik Karlsson — Fri, 29 Apr 2011 06:14:11 +0000

@yched: of course they should be, you’re right. Thanks for your comment

By: yched

yched — Thu, 28 Apr 2011 15:48:23 +0000

the components in the querystring should be encoded :

query += encodeURIComponent(key) + “=” + encodeURIComponent(params[key]) + “&”;

insetad of
query += key + “=” + params[key] + “&”;

By: Erik Karlsson

Erik Karlsson — Mon, 20 Sep 2010 06:21:32 +0000

Pamela, I’m glad you found this useful. I’ll correct the typo in the sample, thanks for pointing it out.

By: Pamela Fox

Pamela Fox — Sun, 19 Sep 2010 23:48:38 +0000

Thanks for this!

I think the sample code should be JSON.get, not JSON.fetch.

Also, I had to add another param to it as I’m using a service that uses a different callback param name than “callback”, unfortunately. Was easy to mod though.

Thanks again!